[FFmpeg-cvslog] r20521 - trunk/libavcodec/alsdec.c

Alex Converse alex.converse
Thu Nov 12 02:52:25 CET 2009


2009/11/11 M?ns Rullg?rd <mans at mansr.com>:
> alexc <subversion at mplayerhq.hu> writes:
>
>> Author: alexc
>> Date: Thu Nov 12 02:44:38 2009
>> New Revision: 20521
>>
>> Log:
>> Fix a __warn_memset_zero_len gcc-4.4 warning.
>>
>> Modified:
>> ? ?trunk/libavcodec/alsdec.c
>>
>> Modified: trunk/libavcodec/alsdec.c
>> ==============================================================================
>> --- trunk/libavcodec/alsdec.c Thu Nov 12 01:07:36 2009 ? ? ? ?(r20520)
>> +++ trunk/libavcodec/alsdec.c Thu Nov 12 02:44:38 2009 ? ? ? ?(r20521)
>> @@ -670,6 +670,7 @@ static void zero_remaining(unsigned int
>> ? ? ?while (b < b_max)
>> ? ? ? ? ?count += div_blocks[b];
>>
>> + ? ?if (count)
>> ? ? ?memset(buf, 0, sizeof(*buf) * count);
>> ?}
>
> That warning is stupid IMHO. ?What's next? ?Why don't they just add
> -Weverything and print something like this:
>
> file.c:1: warning: there might be an error here
> file.c:2: warning: there might be an error here
> ...
>

I agree it's a stupid warning but not only does it spam on a huge
number of lines on the source file compilation it also spams on every
link. Last time it came up we added a similar check.



More information about the ffmpeg-cvslog mailing list