[FFmpeg-cvslog] r20245 - in trunk/libavformat: avformat.h flvenc.c

Stefano Sabatini stefano.sabatini-lala
Fri Oct 16 11:08:18 CEST 2009


On date Friday 2009-10-16 10:37:18 +0200, Reimar D?ffinger wrote:
> On Fri, Oct 16, 2009 at 08:34:25AM +0000, Carl Eugen Hoyos wrote:
> > jbr <subversion <at> mplayerhq.hu> writes:
> > 
> > > +        av_log(enc, AV_LOG_WARNING, "Warning: Adobe Flash Player is known "
> > > +                                    "to have trouble with Speex streams "
> > > +                                    "with more than 8 frames per packet.\n");
> > 
> > Does this message make it clear that the stream in question actually has more
> > than eight frames per packet?
> 
> Hm, it seems a bit too much text anyway, maybe just
> "Speex stream has more than 8 frames per packet, Adobe Flash Player can
> not handle this!"

Yes I prefer this, when the warning is stating a factual truth, though
it is not clear how this is related to the current context, it may be as
well:

"Warning: driving too fast is dangerous and may increase the chance to
smash yourself against something solid!\n." 

"Warning: beware of eating mushrooms collected by unexpert or
malevolent guys!\n"

We may nonetheless add such warnings throughout the code to increase
the level of wisedom of our users.



More information about the ffmpeg-cvslog mailing list