[FFmpeg-cvslog] r20275 - in trunk: doc/vfilters.texi libavfilter/Makefile libavfilter/allfilters.c libavfilter/vf_null.c

Diego Biurrun diego
Sun Oct 18 13:03:51 CEST 2009


On Sun, Oct 18, 2009 at 11:44:33AM +0200, stefano wrote:
> 
> --- trunk/libavfilter/allfilters.c	Sun Oct 18 11:31:57 2009	(r20274)
> +++ trunk/libavfilter/allfilters.c	Sun Oct 18 11:44:33 2009	(r20275)
> @@ -34,6 +34,5 @@ void avfilter_register_all(void)
>  
> +    REGISTER_FILTER (NULL,null,vf);

Spaces after the commas would make this more readable.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ trunk/libavfilter/vf_null.c	Sun Oct 18 11:44:33 2009	(r20275)
> @@ -0,0 +1,56 @@
> +
> +/**
> + * @file libavfilter/vf_null.c
> + * null filter

Is this an audio filter?

> +static AVFilterPicRef *get_video_buffer(AVFilterLink *link, int perms, int w, int h)

Please break needlessly long lines.

> +AVFilter avfilter_vf_null = {
> +    .name      = "null",

Maybe there should be a long description for video filters as well.

Diego



More information about the ffmpeg-cvslog mailing list