[FFmpeg-cvslog] r19771 - trunk/libavcodec/vp3.c

[Reimar Döffinger]

On Sat, Sep 05, 2009 at 05:36:21PM -0400, Alex Converse wrote:
> On Sat, Sep 5, 2009 at 1:28 PM, reimar <subversion at mplayerhq.hu> wrote:
> >
> > Author: reimar
> > Date: Sat Sep ?5 19:28:20 2009
> > New Revision: 19771
> >
> > Log:
> > Make vp3 arrays static const where possible.
> >
> > Modified:
> > ? trunk/libavcodec/vp3.c
> >
> > Modified: trunk/libavcodec/vp3.c
> > ==============================================================================
> > --- trunk/libavcodec/vp3.c ? ? ?Sat Sep ?5 18:41:20 2009 ? ? ? ?(r19770)
> > +++ trunk/libavcodec/vp3.c ? ? ?Sat Sep ?5 19:28:20 2009 ? ? ? ?(r19771)
> >[...]
> > - ? ?signed char travel_width[16] = {
> > + ? ?static const signed char travel_width[16] = {
> >[...]
> > - ? ?signed char travel_height[16] = {
> > + ? ?static const signed char travel_height[16] = {
> >[...]
> > - ? ?signed char travel_width_mb[4] = {
> > + ? ?static const signed char travel_width_mb[4] = {
> >[...]
> > - ? ?signed char travel_height_mb[4] = {
> > + ? ?static const signed char travel_height_mb[4] = {
> >[...]
> > - ? ?int predictor_transform[16][4] = {
> > + ? ?static const int predictor_transform[16][4] = {
> >[...]
> 
> Is there a reason why it is not possible to make "unsigned char
> compatible_frame[8]" static const?

I may simply have missed some arrays.
There are other things that could be improved, e.g. some arrays have a too
large size for what they contain, and int8_t would be nicer to read than
"signed char" etc...