[FFmpeg-cvslog] r22770 - trunk/libavutil/attributes.h

[Michael Niedermayer]

On Sat, Apr 03, 2010 at 05:41:02PM +0100, M?ns Rullg?rd wrote:
> michael <subversion at mplayerhq.hu> writes:
> 
> > Author: michael
> > Date: Fri Apr  2 03:03:27 2010
> > New Revision: 22770
> >
> > Log:
> > av_builtin_constant_p()
> 
> I would prefer calling it simply av_constant_p().  The 'builtin'
> qualifier is a gcc thing.  It's not "built in" to anything "av".

feel free to rename it to whatever you prefer


> 
> > Modified:
> >    trunk/libavutil/attributes.h
> >
> > Modified: trunk/libavutil/attributes.h
> > ==============================================================================
> > --- trunk/libavutil/attributes.h	Fri Apr  2 00:34:22 2010	(r22769)
> > +++ trunk/libavutil/attributes.h	Fri Apr  2 03:03:27 2010	(r22770)
> > @@ -104,4 +104,10 @@
> >  #endif
> >  #endif
> >
> > +#ifdef __GNUC__
> > +#    define av_builtin_constant_p __builtin_constant_p
> > +#else
> > +#    define av_builtin_constant_p(x) 0
> > +#endif
> 
> How bad is it if this isn't available?  We should avoid penalising
> non-gcc compilers unnecessarily.

i dont know

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100404/40bab0ad/attachment.pgp>