[FFmpeg-cvslog] r22946 - trunk/libavutil/log.c

[Michael Niedermayer]

On Fri, Apr 23, 2010 at 11:22:29AM +0200, James Darnley wrote:
> On 23 April 2010 09:59, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> +#ifdef _WIN32
> >> +#include <windows.h>
> >> +#else
> >> ?#include <unistd.h>
> >> +#endif
> >
> > unistd.h needs to be under ifdef?
> 
> Not really, but it isn't used on Windows with the current code.
> 
> >> @@ -39,6 +43,26 @@
> >>
> >> ?#undef fprintf
> >> ?static void colored_fputs(int color, const char *str){
> >> +#ifdef _WIN32
> >> + ? ?int win_color_conv[] = { 0,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_RED|FOREGROUND_INTENSITY,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_GREEN|FOREGROUND_INTENSITY,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_INTENSITY,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_BLUE|FOREGROUND_INTENSITY,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_RED|FOREGROUND_BLUE|FOREGROUND_INTENSITY,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_GREEN|FOREGROUND_BLUE|FOREGROUND_INTENSITY,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE };
> >
> > these could be vertically aligned
> > also the last 3 will not make users happy on white background i suspect
> > isnt there some kind of "default" text color?
> 
> Uh... they are aligned, with the 0 that is.

but the | could be aligned too


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100423/f4f2000f/attachment-0001.pgp>