[FFmpeg-cvslog] r26062 - trunk/libavformat/sdp.c

mstorsjo subversion
Mon Dec 20 21:46:41 CET 2010


Author: mstorsjo
Date: Mon Dec 20 21:46:40 2010
New Revision: 26062

Log:
sdp: Add a framesize attribute to H.263 SDP descriptions

While not mentioned in RFC 4629, this is required for H.263 in
3GPP TS 26.234. It is in practice required for playback with
Android stagefright and on Samsung bada phones.

Modified:
   trunk/libavformat/sdp.c

Modified: trunk/libavformat/sdp.c
==============================================================================
--- trunk/libavformat/sdp.c	Mon Dec 20 10:58:27 2010	(r26061)
+++ trunk/libavformat/sdp.c	Mon Dec 20 21:46:40 2010	(r26062)
@@ -314,7 +314,14 @@ static char *sdp_write_media_attributes(
             break;
         case CODEC_ID_H263:
         case CODEC_ID_H263P:
-            av_strlcatf(buff, size, "a=rtpmap:%d H263-2000/90000\r\n", payload_type);
+            /* a=framesize is required by 3GPP TS 26.234 (PSS). It
+             * actually specifies the maximum video size, but we only know
+             * the current size. This is required for playback on Android
+             * stagefright and on Samsung bada. */
+            av_strlcatf(buff, size, "a=rtpmap:%d H263-2000/90000\r\n"
+                                    "a=framesize:%d %d-%d\r\n",
+                                    payload_type,
+                                    payload_type, c->width, c->height);
             break;
         case CODEC_ID_MPEG4:
             if (c->extradata_size) {



More information about the ffmpeg-cvslog mailing list