[FFmpeg-cvslog] r26033 - trunk/libavcodec/ac3enc.c

Michael Niedermayer michaelni
Tue Dec 21 23:53:07 CET 2010


On Tue, Dec 21, 2010 at 11:51:20PM +0100, Michael Niedermayer wrote:
> On Tue, Dec 21, 2010 at 02:58:59PM -0500, Justin Ruggles wrote:
> > On 12/21/2010 02:39 PM, Justin Ruggles wrote:
> > 
> > > On 12/20/2010 05:44 PM, Justin Ruggles wrote:
> > > 
> > >> On 12/20/2010 05:33 PM, Ronald S. Bultje wrote:
> > >>
> > >>> Hi,
> > >>>
> > >>> On Mon, Dec 20, 2010 at 5:30 PM, Justin Ruggles
> > >>> <justin.ruggles at gmail.com> wrote:
> > >>>> All of the configurations which failed after this revision are x86.
> > >>>
> > >>> Is it possible that one of the optimized functions on these platforms,
> > >>> which isn't tested otherwise, is causing this? E.g. consider that
> > >>> float-to-int routines require different float values depending on
> > >>> optimization level...
> > >>
> > >> I tried all x86 versions of sad[0] (C, MMX, MMX2, SSE2) and they passed
> > >> on my system, so I don't think there is anything fundamentally wrong
> > >> with how ac3enc is using sad[0].
> > > 
> > > 
> > > I was able to duplicate the test failures using OpenBSD 4.8 i386 in
> > > VirtualBox.  Now I'm trying to see if I can track down the specific problem.
> > 
> > 
> > results for different versions of sad[0]:
> > C: ok
> > MMX: fail
> > MMX2: fail
> > SSE2: ok
> > 
> > The x86_32 BSD FATE systems all have 3DNow so they do not use the SSE2
> > version.  Next step: try to figure out what is wrong with the MMX and
> > MMX2 versions.
> 
> wild guess, emms missing?

i see now you have already found and fixed that ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101221/b2c6638e/attachment-0001.pgp>



More information about the ffmpeg-cvslog mailing list