[FFmpeg-cvslog] r20950 - in trunk/libavcodec: h263.h mpegvideo_enc.c

[Michael Niedermayer]

On Mon, Jan 04, 2010 at 04:42:37PM +0100, Diego Biurrun wrote:
> On Fri, Jan 01, 2010 at 09:37:57PM +0100, Michael Niedermayer wrote:
> > On Mon, Dec 28, 2009 at 06:36:03PM +0100, diego wrote:
> > > 
> > > Log:
> > > Replace CONFIG_ANY_H263_ENCODER definition by CONFIG_H263_ENCODER.
> > > CONFIG_ANY_H263_ENCODER is just a logical OR of H.263 family definitions,
> > > for which the build system enables CONFIG_H263_ENCODER anyway.
> > 
> > This is not ideal
> > the common code that any h263 encoder uses is less than what h263
> > encoding as such uses. For example there are things like h263 loop filtering
> > b frames (with motion estimation and all) OBMC, ... in h263 but not in h263
> > like codecs like msmpeg4
> 
> I see no direct relation to the content of my commit.

the relation is that you removed CONFIG_ANY_H263_ENCODER and that is the
define which should be used for the core h263 encoder code.
As it is now you must define h263_encoder and thus must pull all the h263
encoder code in for any codec that uses a subset of the h263 encoder code.


> 
> Other than that, prying apart the H.263 mess is of course welcome.

We should try to have a semantically complete set of CONFIG_* variables
first. And i think CONFIG_ANY_H263_ENCODER is one of them

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100104/983d8056/attachment-0001.pgp>