[FFmpeg-cvslog] r21170 - trunk/libavcodec/alsdec.c

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Tue, Jan 12, 2010 at 08:37:25PM +0000, M?ns Rullg?rd wrote:
>> thilo.borgmann <subversion at mplayerhq.hu> writes:
>> 
>> > Author: thilo.borgmann
>> > Date: Tue Jan 12 21:35:22 2010
>> > New Revision: 21170
>> >
>> > Log:
>> > Replace variable length array with an allocated buffer
>> > in the context to increase compatibility.
>> 
>> What is the maximum size of that anyway?
>
> According to the documentation just below 4kB.

I missed that.

> While it shouldn't be put on the stack, I'd suggest just adding
> it into the context with the maximum size instead of allocating.

What's a typical size?  If it is usually much smaller, 4k is enough
that not always allocating it makes sense.

-- 
M?ns Rullg?rd
mans at mansr.com