[FFmpeg-cvslog] r24033 - trunk/ffmpeg.c

Måns Rullgård mans
Sun Jul 4 01:25:21 CEST 2010


bcoudurier <subversion at mplayerhq.hu> writes:

> Author: bcoudurier
> Date: Sun Jul  4 01:22:25 2010
> New Revision: 24033
>
> Log:
> Fix warning:
> ffmpeg.c: In function 'new_audio_stream':
> ffmpeg.c:665: warning: 'best' may be used uninitialized in this function
> ffmpeg.c:665: note: 'best' was declared here

I would like to request that when fixing actual bugs, the commit
message describe what the bug was and how it was fixed, not only what
the compiler warning was.

> Modified:
>    trunk/ffmpeg.c
>
> Modified: trunk/ffmpeg.c
> ==============================================================================
> --- trunk/ffmpeg.c	Sat Jul  3 23:20:32 2010	(r24032)
> +++ trunk/ffmpeg.c	Sun Jul  4 01:22:25 2010	(r24033)
> @@ -662,7 +662,7 @@ static void choose_sample_rate(AVStream 
>  {
>      if(codec && codec->supported_samplerates){
>          const int *p= codec->supported_samplerates;
> -        int best;
> +        int best;//=0;
>          int best_dist=INT_MAX;

How does this fix anything?

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list