[FFmpeg-cvslog] r23977 - trunk/libavcodec/rl2.c

Diego Biurrun diego
Thu Jul 8 15:28:23 CEST 2010


On Fri, Jul 02, 2010 at 02:15:46PM +0200, Michael Niedermayer wrote:
> On Fri, Jul 02, 2010 at 01:37:54PM +0200, diego wrote:
> > 
> > Log:
> > Remove two more non-existing stray Doxygen function arguments.
> 
> wrong as well

Yes, there is still a bug, one function parameter remains undocumented.
Doxygen generates the following warning for it:

/usr/src/ffmpeg/trunk/libavcodec/rl2.c:172: Warning: The following parameters of rl2_decode_frame(AVCodecContext *avctx, void *data, int *data_size, AVPacket *avpkt) are not documented:
  parameter 'avpkt'

I removed the documentation for two paramaters which no longer exist
in the code, and this change is correct.  Documenting the remaining
parameter is a separate issue.

It would of course be nice if somebody would go ahead and fix that issue
as well.  Given enough time I would even go ahead and fix it myself.
Unfortunately I have a bunch of other things in my todo list ahead of
it currently.

I have introduced neither of the two issues, yet I have volunteered my
time to fix the first bug and clearly the doxygen is now improved due
to my fix.  I would like to respectfully request that you accept my
contribution for the little it's worth and not demand that I fix the
second, separate, issue as well.

Diego



More information about the ffmpeg-cvslog mailing list