[FFmpeg-cvslog] r23977 - trunk/libavcodec/rl2.c

[Michael Niedermayer]

On Thu, Jul 08, 2010 at 02:45:50PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Jul 8, 2010 at 2:38 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > ------------------------------------------------------------------------
> > r18351 | rbultje | 2009-04-07 17:59:50 +0200 (Tue, 07 Apr 2009) | 9 lines
> >
> > Implement avcodec_decode_video2(), _audio3() and _subtitle2() which takes an
> > AVPacket argument rather than a const uint8_t *buf + int buf_size. This allows
> > passing of packet-specific flags from demuxer to decoder, such as the keyframe
> > flag, which appears necessary to playback corePNG P-frames.
> >
> > Patch by Thilo Borgmann thilo.borgmann googlemail com, see also the thread
> > "Google Summer of Code participation" on the mailinglist.
> > ------------------------------------------------------------------------
> >
> > If the burden of fixing the bug has to be placed on somebody, the person
> > who introduced it would seem like a better choice than myself.
> 
> If this (old) commit broke any comments, then the comments should be
> removed. It's silly to add comments to static functions assigned as
> function pointers where the variable it is assigned to already tells
> us everything about the function.

that of course as well, but its still not correct to remove things that
have been renamed or merged and pretend that this fixes anything

[....]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100708/430b48c8/attachment.pgp>