[FFmpeg-cvslog] r23977 - trunk/libavcodec/rl2.c

Måns Rullgård mans
Thu Jul 8 21:30:26 CEST 2010


Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Thu, Jul 08, 2010 at 08:12:02PM +0100, M?ns Rullg?rd wrote:
>> Diego, and everybody else here, is doing his best to help improve
>> things.  The rest of us here have jobs and/or school to share our time
>> with, and try to get the most out of the time we put into FFmpeg.  All
>> too often you have rejected patches for no other reason than not being
>> provably perfect, even though they were without question an
>> improvement.
>
> Well, I do think that more often a "definitely better than what we have"
> would be a good reason to ok a patch on its own.
> However I was a bit annoyed about parts of the patch as well, because it
> seemed remove documentation. Even when it does not apply 100% anymore,
> just removing it in my opinion is far from an improvement, and would have
> warrented at least asking about it before....

I do not see how comments talking about parameters that no longer
exist are in the slightest bit helpful.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list