[FFmpeg-cvslog] r24260 - in trunk/tests: fate2.mak ref/fate/msmpeg4v1

[Michael Niedermayer]

On Fri, Jul 16, 2010 at 03:39:54PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
> >> vitor <subversion at mplayerhq.hu> writes:
> >> 
> >> > Author: vitor
> >> > Date: Fri Jul 16 12:19:21 2010
> >> > New Revision: 24260
> >> >
> >> > Log:
> >> > Revert r24258:
> >> >
> >> > Log:
> >> > Add msmpeg4v1 regtest
> >> >
> >> > Added:
> >> >    trunk/tests/ref/fate/msmpeg4v1
> >> > Modified:
> >> >    trunk/tests/fate2.mak
> >> >
> >> > According to Mans, "make test" tests already msmpeg4v1.
> >> 
> >> Don't believe anything I say.  It was mislabeled, and is testing v3.
> >> 
> >> What's worse, the encoder or decoder appears to be quite broken, so I
> >> can't add a proper test for it either:
> >
> > i dont want to break peoples dreams and hopes but i do not think we ever
> > had a msmpeg4v1 encoder. I felt it would have been wasted time to write/
> > finish it. Supporting the later v2 and v3 seemed sufficient
> 
> So would you approve a patch to rip out the non-working encoder?
> We should either fix it or remove it.

iam ok with removing the struct


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100717/6e492c2b/attachment.pgp>