[FFmpeg-cvslog] r23039 - in trunk/libavfilter: vsrc_buffer.c vsrc_buffer.h
Sat Jul 17 20:49:24 CEST 2010
On Sat, Jul 17, 2010 at 11:36:13AM +0200, Diego Biurrun wrote:
> On Thu, Jun 17, 2010 at 12:06:37PM +0200, Michael Niedermayer wrote:
> > On Thu, Jun 17, 2010 at 11:32:49AM +0200, Diego Biurrun wrote:
> > > On Fri, May 07, 2010 at 03:25:00AM +0200, michael wrote:
> > > >
> > > > Log:
> > > > Add "Memory buffer source filter" from SOC.
> > > > This is needed by the current SOC-ffmpeg.c code.
> > >
> > > As usual you ignore certain requirements..
> > if they can be ignored they hardly could have been required
> > That said this code is from soc and even if you prefer flaming me
> > iam not the author of this file.
> > And of course ive not ignored it but rather i concentrate on getting
> > the code working properly not on things unrelated to code and developers
> > interacting with code (mainntance & readability & so on)
> > aka i forgot about it
> That sure is a set of rules I wish would apply to me.
i wish that too
* you fix issues 7minutes after your first reply
* you concentrate on getting code and documentation in perfect functional
maintainable, readable and fast state, instead of breaking things to hide
> > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> > > > +++ trunk/libavfilter/vsrc_buffer.h Fri May 7 03:25:00 2010 (r23039)
> > > > @@ -0,0 +1,24 @@
> > > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> > > > + */
> > > > +
> > > > +int av_vsrc_buffer_add_frame(AVFilterContext *buffer_filter, AVFrame *frame,
> > > > + int64_t pts, AVRational pixel_aspect);
> > >
> > > ..this is missing multiple inclusion guards and appropriate header
> > > #includes to pass 'make checkheaders'.
> > it does not need multiple inclusion guards
> > it doesnt really need the includes either but ill add them unless you are
> > quicker.
> You never added them.
r23637, just 7 minutes after my mail
> The file could also use a stdint.h #include.
thats unneeded from what i remember
stdint.h or inttypes is amongth the ones included by avfilter/avutil/...
main header which we include already.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-cvslog