[FFmpeg-cvslog] r24443 - trunk/libavcodec/vp8.c

Jason Garrett-Glaser darkshikari
Fri Jul 23 12:37:30 CEST 2010


On Fri, Jul 23, 2010 at 3:34 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
>
>> If you feel your time is too precious to remove cosmetic changes from your
>> patches, please just post them on -devel, I am sure there are enough people
>> being happy to apply them (including me).
>
> Another possibility that I forgot is to simply apply the patch without the
> cosmetics, other developers (and I) have fixed it in the past without
> complaining.
>
> Carl Eugen

"Cosmetics"?  Indentation is not cosmetics, it is part of the code.
Anything that provides information to the reader of the code (human or
compiler) is *by definition* not cosmetics.

I am not going to do extra work for every single patch I submit just
to satisfy your insane definition of "cosmetics" for code you don't
even maintain!

Dark Shikari



More information about the ffmpeg-cvslog mailing list