[FFmpeg-cvslog] r23599 - trunk/libavformat/rtsp.c

mstorsjo subversion
Mon Jun 14 10:23:59 CEST 2010


Author: mstorsjo
Date: Mon Jun 14 10:23:59 2010
New Revision: 23599

Log:
RTSP: Shrink SDP fmtp parsing buffer size

Since the parsing of Vorbis/Theora fmtp headers is handled by the
parse_sdp_a_line function pointer now, the buffer in sdp_parse_fmtp
doesn't need to be this large any longer.

Patch by Josh Allmann, joshua dot allmann at gmail

Modified:
   trunk/libavformat/rtsp.c

Modified: trunk/libavformat/rtsp.c
==============================================================================
--- trunk/libavformat/rtsp.c	Mon Jun 14 10:12:40 2010	(r23598)
+++ trunk/libavformat/rtsp.c	Mon Jun 14 10:23:59 2010	(r23599)
@@ -273,9 +273,7 @@ int ff_rtsp_next_attr_and_value(const ch
 static void sdp_parse_fmtp(AVStream *st, const char *p)
 {
     char attr[256];
-    /* Vorbis setup headers can be up to 12KB and are sent base64
-     * encoded, giving a 12KB * (4/3) = 16KB FMTP line. */
-    char value[16384];
+    char value[4096];
     int i;
     RTSPStream *rtsp_st = st->priv_data;
     AVCodecContext *codec = st->codec;
@@ -541,7 +539,8 @@ static int sdp_parse(AVFormatContext *s,
      * "rulebooks" describing their properties. Therefore, the SDP line
      * buffer is large.
      *
-     * The Vorbis FMTP line can be up to 16KB - see sdp_parse_fmtp. */
+     * The Vorbis FMTP line can be up to 16KB - see xiph_parse_sdp_line
+     * in rtpdec_xiph.c. */
     char buf[16384], *q;
     SDPParseState sdp_parse_state, *s1 = &sdp_parse_state;
 



More information about the ffmpeg-cvslog mailing list