[FFmpeg-cvslog] r23625 - in trunk/libavformat: rtpenc.c rtpenc.h

[Luca Abeni]

On 06/16/2010 03:37 PM, Luca Abeni wrote:
> Hi Ben,
>
> On 06/16/2010 03:17 PM, Benoit Fouet wrote:
> [...]
>>> + case CODEC_ID_H264:
>>> + /* check for H.264 MP4 syntax */
>>> + if (st->codec->extradata_size> 0&& st->codec->extradata&&
>>> + st->codec->extradata[0] == 1) {
>>
>> aren't the two first ones redundant?
>
> You mean, the "st->codec->extradata_size> 0&& st->codec->extradata"?
> I think I've seen cases in which extradata_size != 0 but extradata == NULL,
> or vice-versa... So, better safe than sorry ;-)

I do not seem to be able to reproduce such a situation... So, checking
for extradata_size should be enough. I'll change the check to
"st->codec->extradata_size> 4&& st->codec->extradata[0] == 1", as
suggested by Benoit.


			Thanks,
				Luca