[FFmpeg-cvslog] r23767 - trunk/libavutil/log.c

[Jai Menon]

On Fri, Jun 25, 2010 at 10:19 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> On Fri, Jun 25, 2010 at 1:36 AM, jai_menon <subversion at mplayerhq.hu> wrote:
>> Author: jai_menon
>> Date: Fri Jun 25 06:36:17 2010
>> New Revision: 23767
>>
>> Log:
>> Print a space after the AVClass prefix.
>> This improves readability a bit.
>>
>> Modified:
>> ? trunk/libavutil/log.c
>>
>> Modified: trunk/libavutil/log.c
>> ==============================================================================
>> --- trunk/libavutil/log.c ? ? ? Fri Jun 25 06:29:02 2010 ? ? ? ?(r23766)
>> +++ trunk/libavutil/log.c ? ? ? Fri Jun 25 06:36:17 2010 ? ? ? ?(r23767)
>> @@ -94,10 +94,10 @@ void av_log_default_callback(void* ptr,
>> ? ? ? ? if(avc->version >= (50<<16 | 15<<8 | 3) && avc->parent_log_context_offset){
>> ? ? ? ? ? ? AVClass** parent= *(AVClass***)(((uint8_t*)ptr) + avc->parent_log_context_offset);
>> ? ? ? ? ? ? if(parent && *parent){
>> - ? ? ? ? ? ? ? ?snprintf(line, sizeof(line), "[%s @ %p]", (*parent)->item_name(parent), parent);
>> + ? ? ? ? ? ? ? ?snprintf(line, sizeof(line), "[%s @ %p] ", (*parent)->item_name(parent), parent);
>> ? ? ? ? ? ? }
>> ? ? ? ? }
>> - ? ? ? ?snprintf(line + strlen(line), sizeof(line) - strlen(line), "[%s @ %p]", avc->item_name(ptr), ptr);
>> + ? ? ? ?snprintf(line + strlen(line), sizeof(line) - strlen(line), "[%s @ %p] ", avc->item_name(ptr), ptr);
>> ? ? }
>>
>> ? ? vsnprintf(line + strlen(line), sizeof(line) - strlen(line), fmt, vl);
>
> There are some av_log()s that had a leading space inside the string.
> Those could be removed now.

a quick grep shows

libpostproc/postprocess_template.c
libavcodec/truemotion1.c
libavcodec/libvpxdec.c
libavcodec/cook.c
libavcodec/ituh263dec.c
libavcodec/roqvideodec.c
libavcodec/msrledec.c
libavcodec/roqvideoenc.c
libavcodec/rv10.c
libavcodec/idcinvideo.c
libavcodec/vorbis.c
libavcodec/vqavideo.c
libavcodec/aasc.c
libavcodec/x86/dsputil_mmx.c
libavcodec/interplayvideo.c
libavcodec/vorbis_dec.c
libavcodec/flacdec.c
libavcodec/wmaprodec.c
libavcodec/xan.c
libavcodec/msvideo1.c
libavcodec/libvpxenc.c
libavcodec/flacenc.c
libavcodec/qdm2.c
libavcodec/dca.c
libavcodec/vp3.c
libavcodec/fft-test.c
libavcodec/4xm.c
libavcodec/mpeg4videodec.c
libavformat/wc3movie.c
libavformat/sierravmd.c
libavformat/idroq.c
libavformat/rtmppkt.c
libavformat/libnut.c
libavformat/westwood.c

some of them might be false positives. i'll take a better look in a bit.

> (btw what's up with those wtf language strings in wc3movie.c?)

:)

-- 
Jai Menon