[FFmpeg-cvslog] r23822 - in trunk: ffserver.c libavformat/avformat.h libavformat/gopher.c libavformat/http.c libavformat/internal.h libavformat/mmst.c libavformat/rtmpproto.c libavformat/rtpproto.c libavformat/rts...

Stefano Sabatini stefano.sabatini-lala
Mon Jun 28 00:01:30 CEST 2010


On date Sunday 2010-06-27 22:42:01 +0100, M?ns Rullg?rd wrote:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > On date Sunday 2010-06-27 16:16:46 +0200, mru wrote:
> >> Author: mru
> >> Date: Sun Jun 27 16:16:46 2010
> >> New Revision: 23822
> >> 
> >> Log:
> >> Make ff_url_split() public
> >> 
> >> ff_url_split() is retained as an alias, as it was used by ffserver,
> >> to avoid breaking ABI compatibility with it.
> >
> > There was already a suspended thread about this on ffmpeg-devel, and
> > API changes should be discussed before to be committed. I would have
> > rather preferred av_split_url() as it is more similar to plain
> > English, I find the name av_url_split() (url the split?) rather ugly,
> > now we have to stick with it.
> 

> It was discussed at length, and nobody did anything about it.  Now I
> did.  Suck it up.

It was still discussed and there was a suspendend thread and patch
pending.

> > [...]
> >> Modified: trunk/libavformat/avformat.h
> >> ==============================================================================
> >> --- trunk/libavformat/avformat.h	Sun Jun 27 14:21:12 2010	(r23821)
> >> +++ trunk/libavformat/avformat.h	Sun Jun 27 16:16:46 2010	(r23822)
> >> @@ -1185,6 +1185,32 @@ int64_t av_gen_search(AVFormatContext *s
> >>  int av_set_parameters(AVFormatContext *s, AVFormatParameters *ap);
> >>  
> >>  /**
> >> + * Split a URL string into components.
> >
> > This is also changing the verbal form used, making it inconsistent
> > with the sanctioned style
> 
> Sanctioned exclusively by non-native English-speakers.

Yes the Sun Javadoc spec writers.



More information about the ffmpeg-cvslog mailing list