[FFmpeg-cvslog] r23904 - in trunk: cmdutils.h libavcodec/aac_parser.h libavcodec/ac3.c libavcodec/ac3.h libavcodec/ac3_parser.h libavcodec/ac3tab.c libavcodec/allcodecs.c libavcodec/alsdec.c libavcodec/avcodec.h l...

Michael Niedermayer michaelni
Wed Jun 30 19:41:17 CEST 2010


On Wed, Jun 30, 2010 at 05:38:06PM +0200, mru wrote:
> Author: mru
> Date: Wed Jun 30 17:38:06 2010
> New Revision: 23904
[...]
>  /**
> - * Sets the libav* libraries log level.
> + * Set the libav* libraries log level.
>   */
>  int opt_loglevel(const char *opt, const char *arg);
>  

The 3rd vs. 1st person style has been discussed many times and never
has a majority for this change existed let alone a consensus. Besides
you do not maintain these files that you change and 3rd person is
the recommanded style of javadoc & doxygen. And it also sounds much
better (to me at least).

please revert this commit and refrain from further commits that you know
are controversal, others dont act that offensively either.
Consider your past objections against many changes in mpeg,
about pkgconfig, intreadwrite in libavutil and others. people respected your
objections so please respect others as well.
If you want something controversal changed theres the obvious way of
public discussion and if no consensus can be reached a vote.

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100630/1710401e/attachment.pgp>



More information about the ffmpeg-cvslog mailing list