[FFmpeg-cvslog] r23026 - trunk/libavcodec/libschroedingerenc.c

[Måns Rullgård]

David Conrad <lessen42 at gmail.com> writes:

> On May 8, 2010, at 9:26 AM, Carl Eugen Hoyos wrote:
>
>> M?ns Rullg?rd <mans <at> mansr.com> writes:
>> 
>>> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
>>> 
>>>> conrad <subversion <at> mplayerhq.hu> writes:
>>>> 
>>>>> Author: conrad
>>>>> Date: Wed May  5 23:02:41 2010
>>>>> New Revision: 23026
>>>>> 
>>>>> Log:
>>>>> schroenc: Use constant quality for constant quality, not noise threshold
>>>> 
>>>>> + SCHRO_ENCODER_RATE_CONTROL_CONSTANT_QUALITY);
>>>> 
>>>> You forgot to update configure accordingly.
>>> 
>>> What does configure have to do with it?
>> 
>> SCHRO_ENCODER_RATE_CONTROL_CONSTANT_QUALITY did not exist in 1.0.5, so configure
>> should check for its existence (or the version 1.0.7).
>
> Like so?
>
>
> diff --git a/configure b/configure
> index e14ff6b..7ecd360 100755
> --- a/configure
> +++ b/configure
> @@ -2623,7 +2623,9 @@ enabled libopencore_amrwb  && require libopencore_amrwb opencore-amrwb/dec_if.h
>  enabled libopenjpeg && require libopenjpeg openjpeg.h opj_version -lopenjpeg
>  enabled librtmp    && require  librtmp librtmp/rtmp.h RTMP_Init -lrtmp
>  enabled libschroedinger && add_cflags $(pkg-config --cflags schroedinger-1.0) &&
> -                           require libschroedinger schroedinger/schro.h schro_init $(pkg-config --libs schroedinger-1.0)
> +                           require libschroedinger schroedinger/schro.h schro_init $(pkg-config --libs schroedinger-1.0) &&
> +                           { pkg-config --atleast-version=1.0.7 schroedinger-1.0 ||
> +                             die "ERROR: schroedinger version must be >= 1.0.7"; }

Is 1.0.7 not yet widely (relatively speaking, of course) installed?

-- 
M?ns Rullg?rd
mans at mansr.com