[FFmpeg-cvslog] r25303 - trunk/ffmpeg.c

Aurelien Jacobs aurel
Sun Oct 3 22:21:05 CEST 2010


On Sat, Oct 02, 2010 at 04:31:20PM +0200, Reimar D?ffinger wrote:
> On Sat, Oct 02, 2010 at 04:24:04PM +0200, Diego Biurrun wrote:
> > I don't like breaking down assignments like you propose above.
> > The following is over 80 characters, but still better than what
> > we have right now:
> > 
> > bitstream_filters[nb_output_files] = grow_array(bitstream_filters[nb_output_files],
> >                                                 sizeof(*bitstream_filters[nb_output_files]),
> >                                                 &nb_bitstream_filters[nb_output_files],
> >                                                 oc->nb_streams);
> 
> While we're at bikeshedding, for really long lines
> it IMO is better to break after the =, i.e.
> 
> bitstream_filters[nb_output_files] =
>     grow_array(bitstream_filters[nb_output_files],
>                sizeof(*bitstream_filters[nb_output_files]),
>                &nb_bitstream_filters[nb_output_files], oc->nb_streams);

Applied this version.

Aurel



More information about the ffmpeg-cvslog mailing list