[FFmpeg-cvslog] r25303 - trunk/ffmpeg.c

Aurelien Jacobs aurel
Wed Oct 6 21:24:40 CEST 2010


On Wed, Oct 06, 2010 at 09:23:16PM +0200, Aurelien Jacobs wrote:
> On Tue, Oct 05, 2010 at 04:59:01PM +0300, Martin Storsj? wrote:
> > On Fri, 1 Oct 2010, aurel wrote:
> > 
> > > Author: aurel
> > > Date: Fri Oct  1 23:54:20 2010
> > > New Revision: 25303
> > > 
> > > Log:
> > > ffmpeg: dynamically allocate bitstream_filters
> > 
> > This introduced a regression, in the following command line:
> > 
> > ffmpeg -re -i <input> -an -vcodec mpeg4 vid.mp4 -vn -acodec libfaac 
> > aud.mp4 -newaudio
> 
> This commit actually didn't realy introduced a regression. It "just"
> made an old bug more obvious. Before, the bitstream filter options were
> not assigned to the correct output file when using -newaudio (or
> video...). After this commit it segfault instead of silently doing a
> wrong mapping (which in a way is an improvement, not a regression ;-).
> 
> Attached patch is using nb_output_files-1 as an index instead of
> nb_output_files when treating -newaudio option, because this option is
> refering to the previousy specified file, not the next one.
> It ensures the bitstream filter options are properly mapped, and as a
> consequence, fixes the segfault.
> 
> I will apply very soon if nobody disagree.

I was talking about *this* patch ;-)

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsf_mapping.diff
Type: text/x-diff
Size: 4543 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101006/ae0f8132/attachment.diff>



More information about the ffmpeg-cvslog mailing list