[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Baptiste Coudurier]

On 10/07/2010 03:33 AM, Michael Niedermayer wrote:
> On Wed, Oct 06, 2010 at 08:12:27PM -0700, Baptiste Coudurier wrote:
>> On 10/6/10 7:31 PM, Michael Niedermayer wrote:
>>> On Wed, Oct 06, 2010 at 07:05:22PM -0700, Baptiste Coudurier wrote:
>>>> On 10/06/2010 06:57 PM, michael wrote:
>>>>> Author: michael
>>>>> Date: Thu Oct  7 03:57:39 2010
>>>>> New Revision: 25385
>>>>>
>>>>> Log:
>>>>> Warn if muxing mpeg ps is attempted without a VBV buffer size.
>>>>>
>>>>> Modified:
>>>>>      trunk/libavformat/mpegenc.c
>>>>>
>>>>> Modified: trunk/libavformat/mpegenc.c
>>>>> ==============================================================================
>>>>> --- trunk/libavformat/mpegenc.c	Thu Oct  7 03:57:35 2010	(r25384)
>>>>> +++ trunk/libavformat/mpegenc.c	Thu Oct  7 03:57:39 2010	(r25385)
>>>>> @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
>>>>>                stream->id = mpv_id++;
>>>>>                if (st->codec->rc_buffer_size)
>>>>>                    stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
>>>>> -            else
>>>>> +            else{
>>>>> +                av_log(ctx, AV_LOG_WARNING, "VBV buffer size not set, muxing may fail\n");
>>>>>                    stream->max_buffer_size = 230*1024; //FIXME this is probably too small as default
>>>>> +            }
>>>>
>>>> Humm, this will warn for every VBR encode. I'm not sure at all that is
>>>> wanted.
>>>
>>> VBR has buffers too, so it needs a buffer size too
>>
>> Hummm, but the encoder does not set rc_buffer_size when encoding VBR ?
>
> it does, it even requires it in some cases.
> example:
>   -vb 30MB -minrate 10MB -maxrate 50MB -bt 50MB
> (minrate != maxrate thus not CBR)

.... I'm talking about no maxrate specified.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org