[FFmpeg-cvslog] r25164 - in trunk: Changelog doc/general.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/g722.c

Martin Storsjö martin
Tue Sep 28 21:34:58 CEST 2010


On Tue, 28 Sep 2010, Diego Biurrun wrote:

> On Thu, Sep 23, 2010 at 11:33:29PM +0200, mstorsjo wrote:
> > 
> > Log:
> > Add a G.722 encoder
> > 
> > --- trunk/libavcodec/g722.c	Thu Sep 23 22:23:15 2010	(r25163)
> > +++ trunk/libavcodec/g722.c	Thu Sep 23 23:33:29 2010	(r25164)
> > @@ -219,6 +219,7 @@ static av_cold int g722_init(AVCodecCont
> >  
> > +#if CONFIG_ADPCM_G722_DECODER
> > +#endif
> > +
> > +#if CONFIG_ADPCM_G722_ENCODER
> > +#endif
> 
> Split into separate files instead of the #ifdefs?

Given that the file has ~200 lines of common code, 80 specific to the 
decoder and 70 to the encoder, I feel that splitting it into separate 
files adds too much overhead, since it in that case would be spread out 
over 4 different files.

// Martin



More information about the ffmpeg-cvslog mailing list