[FFmpeg-cvslog] Insert setdar at the begin of a filter chain instead the end.

[Stefano Sabatini]

On date Friday 2011-04-01 17:43:47 +0200, Michael Niedermayer wrote:
> On Fri, Apr 01, 2011 at 04:58:05PM +0200, Michael Niedermayer wrote:
> > On Fri, Apr 01, 2011 at 11:31:57AM +0200, Stefano Sabatini wrote:
> > > On date Friday 2011-04-01 02:29:34 +0200, Michael Niedermayer wrote:
> > > > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Fri Apr  1 02:13:51 2011 +0200| [859676dd426e7051b41b174886e6e64271e93cdc] | committer: Michael Niedermayer
> > > > 
> > > > Insert setdar at the begin of a filter chain instead the end.
> > > > This fixes -vf setsar
> > > 
> > > What is this exactly fixing?
> > 
> > try -vf setsar=anything
> > 
> > it does not work because setdar is added after it
> > or said differently the aspect ratio from the filter chain is totally
> > ignored.
> > 
> > 
> > > 
> > > And setting the filter at the begin of the filterchain won't allow to
> > > set the filterchain output DAR, as the filterchain may insert other
> > > setdar/setsar filters and/or rescale the input video.
> > 
> > the output dar can be set with setdar
> > 
> > 
> > 
> > > 
> > > Also there is the problem in the case "[in]" is specified at the begin
> > > of the user-specified filtergraph description, which will cause a
> > > syntax error.
> > 
> > i see the problem, iam not sure how to fix it best
> 
> i pushed an alternative fix, please comment

Check patch (not correct, working on it, some re-design required),
treat sample_aspect the same way w/h is treated.
-- 
FFmpeg = Foolish and Fundamentalist Multimedia Portentous Evil Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ffmpeg-fix-aspect-ratio-setting.patch
Type: text/x-diff
Size: 4306 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110404/b59758a6/attachment.bin>