[FFmpeg-cvslog] Insert setdar at the begin of a filter chain instead the end.

Michael Niedermayer michaelni at gmx.at
Mon Apr 4 12:31:03 CEST 2011


On Mon, Apr 04, 2011 at 02:46:47AM +0200, Stefano Sabatini wrote:
> On date Friday 2011-04-01 17:43:47 +0200, Michael Niedermayer wrote:
> > On Fri, Apr 01, 2011 at 04:58:05PM +0200, Michael Niedermayer wrote:
> > > On Fri, Apr 01, 2011 at 11:31:57AM +0200, Stefano Sabatini wrote:
> > > > On date Friday 2011-04-01 02:29:34 +0200, Michael Niedermayer wrote:
> > > > > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Fri Apr  1 02:13:51 2011 +0200| [859676dd426e7051b41b174886e6e64271e93cdc] | committer: Michael Niedermayer
> > > > > 
> > > > > Insert setdar at the begin of a filter chain instead the end.
> > > > > This fixes -vf setsar
> > > > 
> > > > What is this exactly fixing?
> > > 
> > > try -vf setsar=anything
> > > 
> > > it does not work because setdar is added after it
> > > or said differently the aspect ratio from the filter chain is totally
> > > ignored.
> > > 
> > > 
> > > > 
> > > > And setting the filter at the begin of the filterchain won't allow to
> > > > set the filterchain output DAR, as the filterchain may insert other
> > > > setdar/setsar filters and/or rescale the input video.
> > > 
> > > the output dar can be set with setdar
> > > 
> > > 
> > > 
> > > > 
> > > > Also there is the problem in the case "[in]" is specified at the begin
> > > > of the user-specified filtergraph description, which will cause a
> > > > syntax error.
> > > 
> > > i see the problem, iam not sure how to fix it best
> > 
> > i pushed an alternative fix, please comment
> 
> Check patch (not correct, working on it, some re-design required),
> treat sample_aspect the same way w/h is treated.

doesnt work, try:
ffmpeg -vframes 3 -y -i ~/videos/matrixbench_mpeg2.mpg test.avi
ffprobe test.avi

Now:
Stream #0.0: Video: mpeg4, yuv420p, 720x576 [PAR 16:15 DAR 4:3], 25 tbr, 25 tbn, 25 tbc

Your patch:
Stream #0.0: Video: mpeg4, yuv420p, 720x576 [PAR 16:15 DAR 4:3], PAR 1:1 DAR 5:4, 25 tbr, 25 tbn, 25 tbc

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110404/894ece4d/attachment.asc>


More information about the ffmpeg-cvslog mailing list