[FFmpeg-cvslog] Disable dr1 in ffplay for svq1 (fixes ticket40)

Michael Niedermayer michaelni at gmx.at
Thu Apr 7 15:20:15 CEST 2011


On Thu, Apr 07, 2011 at 07:33:59AM +0200, Reimar Döffinger wrote:
> 
> 
> On 6 Apr 2011, at 23:46, git at videolan.org (Michael Niedermayer) wrote:
> 
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Wed Apr  6 23:41:02 2011 +0200| [454fab721a2d518d814ce50ab545f89af107851d] | committer: Michael Niedermayer
> > 
> > Disable dr1 in ffplay for svq1 (fixes ticket40)
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=454fab721a2d518d814ce50ab545f89af107851d
> > ---
> > 
> > ffplay.c |    4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/ffplay.c b/ffplay.c
> > index 8c1ea31..2067a8f 100644
> > --- a/ffplay.c
> > +++ b/ffplay.c
> > @@ -1662,7 +1662,9 @@ static int input_init(AVFilterContext *ctx, const char *args, void *opaque)
> >     priv->is = opaque;
> >     codec    = priv->is->video_st->codec;
> >     codec->opaque = ctx;
> > -    if(codec->codec->capabilities & CODEC_CAP_DR1) {
> > +    if((codec->codec->capabilities & CODEC_CAP_DR1)
> > +       && codec->codec_id != CODEC_ID_SVQ1 //chroma alignment from lavfi is insufficient
> 
> The list of codecs with higher chroma alignment requirement in align_dimensions or what it is called is far larger.

> Also MPlayer filters seem to be able to handle it...

mplayer sets emu edge if dr1 is set, which sidesteps the issue.
Ive done the same now with ffplay and will push that soon.

To elaborate more on the issue
theres a 16pixel edge in luma and that ends as a 4 pixel
edge in 410 chroma. Our internal buffer allocation is able to shift the
image to make it still aligned but getting that working with arbitrary
filter graphs and direct rendering between filters does not look
very practical to me.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110407/14b8445b/attachment.asc>


More information about the ffmpeg-cvslog mailing list