[FFmpeg-cvslog] Align stack variables manually in yadif x86 code, should fix ticket25

[Michael Niedermayer]

On Wed, Apr 13, 2011 at 12:02:33AM +0200, Aurelien Jacobs wrote:
> On Thu, Apr 07, 2011 at 01:49:39AM +0200, Michael Niedermayer wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Thu Apr  7 00:31:21 2011 +0200| [4b9c03b7f08f51fea3c8719f169368a46a0d3b63] | committer: Michael Niedermayer
> > 
> > Align stack variables manually in yadif x86 code, should fix ticket25
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> > [...]
> > 
> > +    uint8_t tmp[5*16];
> > +    uint8_t *tmpA= (uint8_t*)(((uint64_t)(tmp+15)) & ~15);
> 
> What about using FFALIGN() here ? It still requires the cast so it's not
> a big improvement, but still.
> See attached patch.
> 
> Aurel
>  yadif_template.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 19b78bf6b700fce43bd65c9aae9f31098988b928  0001-yadif-use-FFALIGN-instead-of-reimplementing-it.patch
> From 3c6a1681a70b6add92eda0b48e61410f50de1dc2 Mon Sep 17 00:00:00 2001
> From: Aurelien Jacobs <aurel at gnuage.org>

ok of course if uintptr is used elewhere already

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110413/2dff1c80/attachment.asc>