[FFmpeg-cvslog] Add key_frame and pict_type to AVFilterBufferRefVideo.

Alexander Strasser eclipse7 at gmx.net
Sat Apr 16 15:03:16 CEST 2011


Stefano Sabatini wrote:
> On date Saturday 2011-04-16 10:10:14 +0200, Roger Pau Monné wrote:
> > ffmpeg | branch: master | Roger Pau Monné <roger.pau at entel.upc.edu> | Sat Apr 16 10:09:15 2011 +0200| [09a1416db78f49fb3a39cdf5a4bd0f5c5f849ce0] | committer: Carl Eugen Hoyos
[...]
> > diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> > index f270a37..16c761a 100644
> > --- a/libavfilter/avfilter.h
> > +++ b/libavfilter/avfilter.h
> > @@ -26,7 +26,7 @@
> >  #include "libavutil/samplefmt.h"
> >  
> >  #define LIBAVFILTER_VERSION_MAJOR  1
> > -#define LIBAVFILTER_VERSION_MINOR 78
> > +#define LIBAVFILTER_VERSION_MINOR 79
> >  #define LIBAVFILTER_VERSION_MICRO  0
> >  
> >  #define LIBAVFILTER_VERSION_INT AV_VERSION_INT(LIBAVFILTER_VERSION_MAJOR, \
> > @@ -115,6 +115,8 @@ typedef struct AVFilterBufferRefVideoProps {
> >      AVRational pixel_aspect;    ///< pixel aspect ratio
> >      int interlaced;             ///< is frame interlaced
> >      int top_field_first;        ///< field order
> > +    int pict_type;              ///< Picture type of the frame
> > +    int key_frame;              ///< 1 -> keyframe, 0-> not
> 
> I'm not very happy about this.
> 
> Indeed pict_type is not explained, which are the assumed values? Also
> pict_type is defined in libavcodec, would make sense to move the
> FF_*_TYPE_ definitions to libavutil?

  I really knew this would happen. Do you really think moving all that
stuff into libavutil is more sane than depending on libavcodec?

  This seems to fit the category I mentioned on ffmpeg-devel which I
tagged with libavfilter could make use of more things defined in
libavcodec.

  Please pardon me sounding so harsh, I am just very unhappy with the
lavu mess that was created at the beginning of this year. I know that
you tried to do much better.

  Alexander


More information about the ffmpeg-cvslog mailing list