[FFmpeg-cvslog] ffmpeg: fix aspect ratio setting

Baptiste Coudurier baptiste.coudurier at gmail.com
Sun Apr 17 01:48:01 CEST 2011


On 4/6/11 4:19 PM, Stefano Sabatini wrote:
> On date Wednesday 2011-04-06 15:50:37 -0700, Baptiste Coudurier wrote:
>> On 04/06/2011 10:44 AM, Stefano Sabatini wrote:
>>> On date Tuesday 2011-04-05 15:02:08 -0700, Baptiste Coudurier wrote:
>>>> On 04/05/2011 12:09 PM, Baptiste Coudurier wrote:
>>> [...]
>>>>>> That said, I don't see a sane way to make -vf and -aspect convive when
>>>>>> filtering is enabled, that is i'd tend to say to the user to just use
>>>>>> -vf when she wants to change the final aspect (and keep -aspect for
>>>>>> -vcodec copy).
>>>>>
>>>>> Having 2 options is confusing for the user.
>>>>>
>>>>> I think the correct solution is to avoid adding filters when -aspect is
>>>>> specified on the commandline, and check frame_aspect_ratio directly.
>>>>> My first patch did this. It's easy to distinguish between -aspect
>>>>> specified or not.
>>>>>
>>>>> If it was, override the output aspect ratio no matter what (at the end
>>>>> of configure_filters)
>>>>>
>>>>
>>>> Patch attached.
>>>>
>>>> -- 
>>>> Baptiste COUDURIER
>>>> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
>>>> FFmpeg maintainer                                  http://www.ffmpeg.org
>>>
>>>> From 4ebbb6a5f34dd8d39610a9185eac5f7a925f2141 Mon Sep 17 00:00:00 2001
>>>> From: Baptiste Coudurier <baptiste.coudurier at gmail.com>
>>>> Date: Tue, 5 Apr 2011 13:37:11 -0700
>>>> Subject: [PATCH] Fix -aspect cli option
>>>
>>> Please extend the commit log so that we have some more information
>>> stored in metadata for the next poor guy trying to figure this out.
>>
>> Please suggest another message.
> 
> ffmpeg: fix -aspect cli option
> 
> Redesign the way -aspect option is handled. This is done by making
> ffmpeg read the sample aspect ratio set in the corresponding input
> stream by default, and overriding it using the value specified by
> -aspect.
> 
> If the output display aspect ratio is specified with -aspect, it is
> set at the end of the filterchain, thus overriding the value set by
> filters in the filterchain.
> 
> This implementation is more robust, since does not modify the
> filterchain description (which was creating potential syntax errors).

Applied with this message.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org


More information about the ffmpeg-cvslog mailing list