[FFmpeg-cvslog] Ogg: add support for Xiph's CELT (Opus) codec.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Apr 19 19:48:49 CEST 2011


On Tue, Apr 19, 2011 at 04:12:26PM +0200, Nicolas George wrote:
> +        av_free(os->private);
> +        av_free(st->codec->extradata);
[...]
> +        st->codec->extradata      = extradata;
> +        st->codec->extradata_size = 2 * sizeof(uint32_t);
[...]
> +        os->private = priv;
> +        AV_WL32(extradata + 0, overlap);
> +        AV_WL32(extradata + 4, version);

IMO this would be far more readable if the corresponding
frees, assignments and writes were grouped together instead
of this wild mixture.

> +        if (sample_rate)
> +            av_set_pts_info(st, 64, 1, sample_rate);

The "if" should be pointless, without it you'd actually
get a proper warning message.


More information about the ffmpeg-cvslog mailing list