[FFmpeg-cvslog] Ogg: add support for Xiph's CELT (Opus) codec.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Apr 19 23:56:49 CEST 2011


On 19 Apr 2011, at 23:40, Nicolas George <nicolas.george at normalesup.org> wrote:

> Le decadi 30 germinal, an CCXIX, Reimar Döffinger a écrit :
>> IMO this would be far more readable if the corresponding
>> frees, assignments and writes were grouped together instead
>> of this wild mixture.
> 
> I concede you slightly more readable.

I'll concede the exaggeration, but it took me a bit of time to figure out what's going on with extradata.

> 
>> The "if" should be pointless, without it you'd actually
>> get a proper warning message.
> 
> I copied the logic from oggparsevorbis, which is wrong too. This one is
> fixed.

Well to be fair it is rather outdated than wrong originally.


More information about the ffmpeg-cvslog mailing list