[FFmpeg-cvslog] HTTP playback is broken due to 59d96941f0285a501989d5f2c9b69be0a1393ed5

avcoder ffmpeg at gmail.com
Wed Apr 20 16:57:00 CEST 2011


Hi,  you modification is almost OK.

the tiny fix is:

change the

if ((h->flags & AVIO_FLAG_WRITE))

to

if (!(h->flags & AVIO_FLAG_READ))

in ffurl_read() and ffurl_read_complete()


On Wed, Apr 20, 2011 at 10:12 PM, avcoder <ffmpeg at gmail.com> wrote:

>
>
> On Wed, Apr 20, 2011 at 9:55 PM, Nicolas George <
> nicolas.george at normalesup.org> wrote:
>
>> Le primidi 1er floréal, an CCXIX, avcoder a écrit :
>> > The modification is wrong, it breaks the original logic,
>>
>> The original logic was flawed.
>>
>> >                                                          eg: it breaks
>> HTTP
>> > playback.
>>
>> Please elaborate.
>>
>>
> The short answer is : it breaks all AVIO_FLAG_READ_WRITE usage
>
> --
>
> -----------------------------------------------------------------------------------------
> My key fingerprint: d1:03:f5:32:26:ff:d7:3c:e4:42:e3:51:ec:92:78:b2
>



-- 
-----------------------------------------------------------------------------------------
My key fingerprint: d1:03:f5:32:26:ff:d7:3c:e4:42:e3:51:ec:92:78:b2


More information about the ffmpeg-cvslog mailing list