[FFmpeg-cvslog] mp3enc: write ISO8859-1 instead of UTF-16 when possible

Reimar Döffinger Reimar.Doeffinger
Mon Feb 7 07:35:33 CET 2011


On Sun, Feb 06, 2011 at 10:47:59PM +0100, Anton Khirnov wrote:
> On Sun, Feb 06, 2011 at 10:02:17PM +0100, Arpi wrote:
> > Hi,
> > 
> > this code is better than nothing but far from being perfect and far from
> > being what the comment/commitmsg says.
> > 
> > iso 8859-1 charset are 32..255 and not 1..127 what the check verifies.
> > a correct check and conversion although requires utf8 decoding, which
> > is a bit tricky, especially if you check for bougus data, for example
> > the string-termitor zero byte after an utf8 prefix...
> Well spotted, thank you.
> I don't think handling the 128-255 range is worth the effort.
> Lower bound fixed.

Uh, 1-32 are the same for 8859-1, ASCII and UTF-* to my knowledge, so it is silly
to switch back to UTF-16 in that case...



More information about the ffmpeg-cvslog mailing list