[FFmpeg-cvslog] mmsh: fixed printf injection bug in mmsh request

Kirill Zorin git at videolan.org
Fri Jun 17 05:54:04 CEST 2011


ffmpeg | branch: master | Kirill Zorin <cyril.zorin at gmail.com> | Wed Jun 15 19:18:29 2011 +0200| [6095388812ce1b2a95e9917b89e5857639208f88] | committer: Martin Storsjö

mmsh: fixed printf injection bug in mmsh request

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6095388812ce1b2a95e9917b89e5857639208f88
---

 libavformat/mmsh.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavformat/mmsh.c b/libavformat/mmsh.c
index b19973e..af040e2 100644
--- a/libavformat/mmsh.c
+++ b/libavformat/mmsh.c
@@ -231,7 +231,7 @@ static int mmsh_open(URLContext *h, const char *uri, int flags)
         host, sizeof(host), &port, path, sizeof(path), location);
     if (port<0)
         port = 80; // default mmsh protocol port
-    ff_url_join(httpname, sizeof(httpname), "http", NULL, host, port, path);
+    ff_url_join(httpname, sizeof(httpname), "http", NULL, host, port, "%s", path);
 
     if (ffurl_alloc(&mms->mms_hd, httpname, AVIO_FLAG_READ) < 0) {
         return AVERROR(EIO);



More information about the ffmpeg-cvslog mailing list