[FFmpeg-cvslog] In retry_transfer_wrapper, do not check url_interrupt_cb,

Nicolas George nicolas.george
Fri Mar 4 17:23:51 CET 2011

Le quartidi 14 vent?se, an CCXIX, Martin Storsj? a ?crit?:
> Perhaps a fix which would match the old behaviour more closely wold be to 
> move the url_interrupt_cb() check down, either into the if (EAGAIN) 
> branch, or at least to after transfer_func has been called. That way, 
> url_interrupt_cb() triggering won't make writes to local files fail, which 
> wouldn't have blocked anyway.

I believe the attached patch fixes things.

I am not quite happy with the whole thing, but I believe this can not be
avoided: we are in the situation of the unstoppable bullet hitting the
unbreakable armor: url_read_complete and url_write both guarantee to
read/write all the requested data unless something fatal happened, while
url_interrupt_cb guarantees to interrupt any transfer. In the end,
url_interrupt_cb wins, but it necessarily kills the protocol context.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-retry_transfer_wrapper-check-url_interrupt_cb-at-the.patch
Type: text/x-diff
Size: 1108 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110304/12390940/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110304/12390940/attachment.pgp>

More information about the ffmpeg-cvslog mailing list