[FFmpeg-cvslog] Bitmap Brothers JV demuxer

Michael Niedermayer michaelni
Fri Mar 11 21:00:49 CET 2011


On Fri, Mar 11, 2011 at 07:36:45PM +0100, Reimar D?ffinger wrote:
> On Fri, Mar 11, 2011 at 12:50:27PM +0100, Peter Ross wrote:
[...]
>
> > +        jvf->video_size = avio_rl32(pb);
> 
> > +                int size = jvf->video_size + (jvf->palette ? 768 : 0);
> > +                if (av_new_packet(pkt, size + 5))
> 
> These can overflow, unless I miss something?

looks so to me too

/me looks towards reviewer kostya ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110311/5221571d/attachment-0001.pgp>



More information about the ffmpeg-cvslog mailing list