[FFmpeg-cvslog] fraps: check for overread

compn tempn at twmi.rr.com
Thu Nov 10 00:18:30 CET 2011


On Wed, 9 Nov 2011 20:13:07 +0100, Reimar Döffinger wrote:
>On Wed, Nov 09, 2011 at 08:05:04PM +0100, Michael Niedermayer wrote:
>> On Wed, Nov 09, 2011 at 07:18:48PM +0100, Reimar Döffinger wrote:
>> > On Wed, Nov 09, 2011 at 12:18:45AM +0100, Michael Niedermayer wrote:
>> > Philosophically I also disagree a bit with failing completely when
>> > we (probably) managed to decode a large part of the frame perfectly
>> > fine, doubly so because fraps reuses the previous frame which means
>> > we actually would have kind of error concealment.
>> 
>> simply ignoring the failure end exiting causes 3/4 of the frame to be
>> trashed from the sample of ticket619
>> i see some in place yuv-rgb transform, which may be the cause but i
>> did not investigate
>
>Ok, fine. I still intend to bring this up next time I suggest
>introducing proper flagging of decode issues instead of only "fail" via
>return value and everyone's again more interesting in fixing their
>special case only...

a lot of users i've talked to would rather have the ability to look at
corrupted/incomplete video instead of exiting. of course this is mostly
for mpeg4 video not fraps. ;)

-compn


More information about the ffmpeg-cvslog mailing list