[FFmpeg-cvslog] imgutils: Fix illegal read.

Thierry Foucu git at videolan.org
Tue Nov 22 02:38:13 CET 2011


ffmpeg | branch: oldabi | Thierry Foucu <tfoucu at gmail.com> | Fri Nov 18 17:36:50 2011 -0800| [4007352bd054936fe06cb8b726db008b47101d91] | committer: Michael Niedermayer

imgutils: Fix illegal read.

Found with address sanitizer.

Signed-off-by: Alex Converse <alex.converse at gmail.com>
(cherry picked from commit c693aa6f71b4f539cf9df67ba42f4b1932981687)

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4007352bd054936fe06cb8b726db008b47101d91
---

 libavutil/imgutils.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c
index e04c307..5033d0d 100644
--- a/libavutil/imgutils.c
+++ b/libavutil/imgutils.c
@@ -125,7 +125,7 @@ int av_image_fill_pointers(uint8_t *data[4], enum PixelFormat pix_fmt, int heigh
         has_plane[desc->comp[i].plane] = 1;
 
     total_size = size[0];
-    for (i = 1; has_plane[i] && i < 4; i++) {
+    for (i = 1; i < 4 && has_plane[i]; i++) {
         int h, s = (i == 1 || i == 2) ? desc->log2_chroma_h : 0;
         data[i] = data[i-1] + size[i-1];
         h = (height + (1 << s) - 1) >> s;



More information about the ffmpeg-cvslog mailing list