[FFmpeg-cvslog] Move av_tempfile() into libavutil, it is a generically usefull thing and its small.

Michael Niedermayer michaelni at gmx.at
Sun Oct 16 22:16:07 CEST 2011


On Sun, Oct 16, 2011 at 09:42:12PM +0200, Reimar Döffinger wrote:
> On Sun, Oct 16, 2011 at 09:35:26PM +0200, Michael Niedermayer wrote:
> > On Sun, Oct 16, 2011 at 09:22:11PM +0200, Reimar Döffinger wrote:
> > > On Sun, Oct 16, 2011 at 05:21:22PM +0200, Michael Niedermayer wrote:
> > > > -    fd = open(*filename, O_RDWR | O_BINARY | O_CREAT, 0444);
> > > 
> > > Adding O_EXCL should increase security here.
> > > Seems supported at least on Linux and Windows.
> > > Might fail compilation on some systems though.
> > 
> > fixed locally
> 
> Oh, and did you fix the 0444 mode? That seems both like
> a bad idea and mismatches mkstemp behaviour.

fixed locally, anything else that needs fixing?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20111016/c55c3318/attachment.asc>


More information about the ffmpeg-cvslog mailing list