[FFmpeg-cvslog] nsvdec: Propagate errors

Alex Converse git at videolan.org
Mon Apr 2 01:45:25 CEST 2012


ffmpeg | branch: release/0.8 | Alex Converse <alex.converse at gmail.com> | Thu Jan 26 17:23:09 2012 -0800| [0100c4b1b0736e0f5b3c98f9b0ab8acbef574888] | committer: Reinhard Tartler

nsvdec: Propagate errors

Related to CVE-2011-3940.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
(cherry picked from commit c898431ca5ef2a997fe9388b650f658fb60783e5)

Conflicts:

	libavformat/nsvdec.c

Signed-off-by: Reinhard Tartler <siretart at tauware.de>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0100c4b1b0736e0f5b3c98f9b0ab8acbef574888
---

 libavformat/nsvdec.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c
index 7041523..67c103d 100644
--- a/libavformat/nsvdec.c
+++ b/libavformat/nsvdec.c
@@ -523,11 +523,16 @@ static int nsv_read_header(AVFormatContext *s, AVFormatParameters *ap)
     for (i = 0; i < NSV_MAX_RESYNC_TRIES; i++) {
         if (nsv_resync(s) < 0)
             return -1;
-        if (nsv->state == NSV_FOUND_NSVF)
+        if (nsv->state == NSV_FOUND_NSVF) {
             err = nsv_parse_NSVf_header(s, ap);
+            if (err < 0)
+                return err;
+        }
             /* we need the first NSVs also... */
         if (nsv->state == NSV_FOUND_NSVS) {
             err = nsv_parse_NSVs_header(s, ap);
+            if (err < 0)
+                return err;
             break; /* we just want the first one */
         }
     }



More information about the ffmpeg-cvslog mailing list