[FFmpeg-cvslog] matroskadec: properly fall back to generic seek.
michaelni at gmx.at
Mon Feb 13 21:30:27 CET 2012
On Mon, Feb 13, 2012 at 09:28:48PM +0100, Reimar Döffinger wrote:
> On Mon, Feb 13, 2012 at 09:06:31PM +0100, Michael Niedermayer wrote:
> > On Mon, Feb 13, 2012 at 08:05:12PM +0100, Reimar Döffinger wrote:
> > > ffmpeg | branch: master | Reimar Döffinger <Reimar.Doeffinger at gmx.de> | Sun Feb 12 14:09:03 2012 +0100| [47e015e6f1913f7da943898eb7716a954f947ff7] | committer: Reimar Döffinger
> > >
> > > matroskadec: properly fall back to generic seek.
> > >
> > > In particular, detect when the index is obviously broken.
> > > This fixes the worst symptoms of trac issue #958 and makes
> > > sense to allow seeking in files without index.
> > > However it is possible that there still is an index parsing bug
> > > with that file.
> > >
> > > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > either this or the previous commit broke fate: (seektest)
> > http://fate.ffmpeg.org/report.cgi?time=20120213193820&slot=x86_64-freebsd8.2-clang2.8
> This one. I must have forgotten to run the test once more
> after some last changes.
> But do you think the new result is wrong?
> Previously it would say "seek ok" and then immediately return EOF
> on the next read, now the seek will fail directly (if I read the
> diff correctly).
> Behaviour seems a bit inconsistent, but only these behave the way
> mkv did before, so the majority seem to agree with the new behaviour:
iam not against the new behavior, just the failing tests (as it hides
other possible failures)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have often repented speaking, but never of holding my tongue.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-cvslog