[FFmpeg-cvslog] Revert "Fix channel layout for some stereo flac files."

Michael Niedermayer michaelni at gmx.at
Sun Feb 26 21:11:36 CET 2012

On Sun, Feb 26, 2012 at 08:58:32PM +0100, Nicolas George wrote:
> Le septidi 7 ventôse, an CCXX, Nicolas George a écrit :
> > Le sextidi 6 ventôse, an CCXX, Michael Niedermayer a écrit :
> > > -        if (fi->ch_mode <= 5)
> > > -            avctx->channel_layout = ff_vorbis_channel_layouts[fi->ch_mode];
> > This one I see was not right: Vorbis and FLAC use different channels order
> > and layouts.
> After checking the spec more carefully, it seems my memory tricked me: FLAC
> and Vorbis really have the same channels up to 6 channels, only not in the
> same order, but the order does not appear in channel_layout.
> I would really like to know why this had to be reverted.

i think carl told me to revert it but maybe i misunderstood him, it
was more git commands than words
paul also pointed a bit toward reverting something which had led me to
ask carl ...

I was just intending to remove redundant and or not correct code, and
have/had not investigated this deeply.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120226/6b319ebf/attachment.asc>

More information about the ffmpeg-cvslog mailing list