[FFmpeg-cvslog] mxfdec: Handle small EditUnitByteCount

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Jan 25 19:27:42 CET 2012


On Tue, Jan 24, 2012 at 05:35:17PM +0100, Tomas Härdin wrote:
> +    /* expect PCM with exactly one index table segment and a small (< 32) EUBC */
> +    if (s->nb_streams != 1 || s->streams[0]->codec->codec_type != AVMEDIA_TYPE_AUDIO ||
> +        !is_pcm(s->streams[0]->codec->codec_id) || mxf->nb_index_tables != 1 ||
> +        mxf->index_tables[0].nb_segments != 1 ||
> +        mxf->index_tables[0].segments[0]->edit_unit_byte_count >= 32)

That's a lot more conditions than the comment says.
I think it would really be useful to document what the purpose
of all these is, since naively I would have thought you could just
merge anything that has very small edit units.


More information about the ffmpeg-cvslog mailing list