[FFmpeg-cvslog] r210, r10k and avrp encoder

[Michael Niedermayer]

Hi

after the release now, ill try to reply more elaborately


On Thu, Jan 26, 2012 at 11:47:30PM +0100, Michael Niedermayer wrote:
> On Thu, Jan 26, 2012 at 11:08:16PM +0100, Reimar Döffinger wrote:
> > On Thu, Jan 26, 2012 at 10:42:43PM +0100, Michael Niedermayer wrote:
> > > On Thu, Jan 26, 2012 at 10:10:02PM +0100, Reimar Döffinger wrote:
> > > > On 26 Jan 2012, at 20:01, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > > > On Thu, Jan 26, 2012 at 08:45:09AM +0100, Reimar Döffinger wrote:
> > > > >> 
> > > > >>> +    avctx->coded_frame->reference = 0;
> > > > >>> +    avctx->coded_frame->key_frame = 1;
> > > > >>> +    avctx->coded_frame->pict_type = AV_PICTURE_TYPE_I;
> > > > >> 
> > > > >> That makes yet two more encoders for which pts is not handled correctly.
> > > > > 
> > > > > why ?
> > > > > 
> > > > > avctx->coded_frame = avcodec_alloc_frame();
> > > > > should set all the pts fields to AV_NOPTS_VALUE
> > > > 
> > > > And why should the outgoing pts be AV_NOPTS_VALUE when the incoming is not?

1. historic reasons.
    Some codecs needed pts reordering and development didnt stop
    for 5 years because there was noone volunteering to change all
    decoders to pass it through.
2.
    Its simpler and less error prone for the most common case.



> > > > And how would you distinguish the cases where the encoder just never sets pts vs. an encoder that just (possibly with reordering) passed through a AV_NOPTS_VALUE it got as input?

id say you dont have to feed the encoder with AV_NOPTS_VALUE, there
are plenty of other values. if you do still you wont be able to tell
them apart so easily though maybe CODEC_CAP_DELAY could be used to
imply a 1:1 relation

Also, AV_NOPTS_VALUE means unknown, and a encoder "returning" 
AV_NOPTS_VALUE means it didnt know the timestamp it doesnt say anything
about the relation or lack thereof to the input.

either way, we should work toward fixing the bugs/problems with this
system

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120127/11aab6ac/attachment.asc>