[FFmpeg-cvslog] mathematics: Don't use division by zero in NAN/INFINITY macros

Carl Eugen Hoyos cehoyos at ag.or.at
Sun Jul 8 14:29:19 CEST 2012


Alexander Strasser <eclipse7 <at> gmx.net> writes:

> > > mathematics: Don't use division by zero in NAN/INFINITY macros
> > > 
> > > Some compilers, MSVC among them, don't recognize the divisions by
> > > zero as meaning infinity/nan.
> > > 
> > > These macros should, according to the standard, expand to constant
> > > expressions, but this shouldn't matter for our usage.
> > 
> > mathematics.h to my knowledge is an installed header, IMHO 
> > this is an API change and changes should not be
> > made looking only at what FFmpeg needs.
> > Also at least for INF I believe the correct way is to 
> > define it to _HUGE_VAL for MSVC.
> 
>   FWIW I fully agree to this reasoning.

Then please revert the change.

Sorry, I did not really read what it is about and have 
no opinion but if unexpectedly reverts a feature, please 
undo the patch.

Carl Eugen



More information about the ffmpeg-cvslog mailing list