[FFmpeg-cvslog] vf_overlay: prevent premature freeing of cur_buf

compn tempn at twmi.rr.com
Fri Jul 27 01:07:17 CEST 2012


On Fri, 27 Jul 2012 00:02:24 +0200, Michael Niedermayer wrote:
>On Thu, Jul 26, 2012 at 11:17:42PM +0200, Nicolas George wrote:
>> Le nonidi 9 thermidor, an CCXX, Michael Niedermayer a écrit :
>> > @@ -238,6 +238,7 @@ static int start_frame_overlay(AVFilterLink *inlink, AVFilterBufferRef *inpicref
>> >      AVFilterContext *ctx = inlink->dst;
>> >      OverlayContext *over = ctx->priv;
>> >  
>> > +    inlink->cur_buf  = NULL;
>> >      over->overpicref = inpicref;
>> >      over->overpicref->pts = av_rescale_q(inpicref->pts, ctx->inputs[OVERLAY]->time_base,
>> >                                           ctx->outputs[0]->time_base);
>> 
>> They made the same mistake I made in 9c1d649 (and that the patch I sent a
>> few hours ago fixes). It's rather tasteless to put your name on a bogus
>> commit just because it was cherry-picked from a completely different, good,
>> commit.
>
>I have the suspicion noone will understand this paragraph.
>I myself had to read it twice. First time i thought iam being
>accused of having put my name on something. But that being a commit
>by luca the correct interpretation must be that its tasteless from
>luca to put my name on a buggy line from a good commit.
>

the problem is that Nicolas George made a patch, committed the
patch to ffmpeg, and libav has committed it with incorrect attribution.

>committer: Luca Barbato
>vf_overlay: prevent premature freeing of cur_buf
>Signed-off-by: Anton Khirnov <anton at khirnov.net>
>Signed-off-by: Luca Barbato <lu_zero at gentoo.org>

http://lists.libav.org/pipermail/libav-devel/2012-July/031764.html
http://lists.libav.org/pipermail/libav-commits/2012-July/007459.html

for some reason anton attributed it to michael. obviously its not a
merge (like michael does from qatar). maybe its a manual patch made by
anton?

-compn


More information about the ffmpeg-cvslog mailing list